refactor(cli): convert debug agent command to effectCmd#25485
Merged
kitlangton merged 1 commit intodevfrom May 2, 2026
Merged
Conversation
Drops bootstrap() + 3 AppRuntime.runPromise wrappers. Helpers
(getAvailableTools, createToolContext) now return Effects yielded
directly. Instance.directory/.worktree → ctx.directory/.worktree from
InstanceRef. process.exit(1) → fail("", 1) for the three error paths
(stderr message printed inline, exit code 1).
Bonus fix: --tool execution path was awaiting tool.execute() which
returns an Effect (not a Promise), so result was the Effect object
itself — JSON.stringify produced garbage. Now properly yields the Effect
to get the ExecuteResult.
kitlangton
commented
May 2, 2026
| }), | ||
| ) | ||
| } | ||
| const getAvailableTools = Effect.fn("Cli.debug.agent.getAvailableTools")(function* (agent: Agent.Info) { |
kitlangton
commented
May 2, 2026
| }), | ||
| ) | ||
| } | ||
| const getAvailableTools = Effect.fn("Cli.debug.agent.getAvailableTools")(function* (agent: Agent.Info) { |
kitlangton
commented
May 2, 2026
| @@ -7,14 +7,14 @@ import { Session } from "@/session/session" | |||
| import type { MessageV2 } from "../../../session/message-v2" | |||
kitlangton
commented
May 2, 2026
| @@ -7,14 +7,14 @@ import { Session } from "@/session/session" | |||
| import type { MessageV2 } from "../../../session/message-v2" | |||
kitlangton
commented
May 2, 2026
| }), | ||
| ) | ||
| } | ||
| const getAvailableTools = Effect.fn("Cli.debug.agent.getAvailableTools")(function* (agent: Agent.Info) { |
kitlangton
commented
May 2, 2026
| @@ -7,14 +7,14 @@ import { Session } from "@/session/session" | |||
| import type { MessageV2 } from "../../../session/message-v2" | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Behavioral notes (subagent purity audit)
MOSTLY PURE WITH NOTES — pure on the agent-info path; observable improvements on error paths:
Test plan